Add udp template to virtual_port_templates and changed param names for tcp and udp template #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r tcp and udp template
afrin-chakure-a10
suggested changes
Sep 21, 2020
|
Also kindly update the corresponding unit tests. |
hthompson6
suggested changes
Sep 22, 2020
afrin-chakure-a10
suggested changes
Sep 24, 2020
There was a problem hiding this comment.
Hi @JLau1596
Please fix Unit tests which would also fix the failing Travis.
Changed tcp_template and udp_template to template-tcp and template-udp
|
Hi @JLau1596 Seems to be some merge conflicts on some files. Can you resolve them? |
|
Hi @afrin-chakure-a10 I think I have fixed the merge conflict, can you please review it? |
I see travis failure for UTs (I understand they are due to latest changes on same UT files.) Can you fix them? Thanks |
| @@ -142,9 +140,9 @@ def _set( | |||
| if source_nat_pool and len(source_nat_pool) > 0: | |||
| params['port']['pool'] = source_nat_pool | |||
| if tcp_template: | |||
| params['port']['tcp_template'] = tcp_template | |||
| params['port']['template-tcp'] = tcp_template | |||
There was a problem hiding this comment.
@hthompson-a10
This code seems to override LOC 123. Should we allow it? or more conditions needs to be added for preference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add udp template to virtual_port_templates and changed param names for tcp and udp template