Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track already searched events #524

Closed
wants to merge 1 commit into from
Closed

Track already searched events #524

wants to merge 1 commit into from

Conversation

0xPxt
Copy link
Collaborator

@0xPxt 0xPxt commented Feb 14, 2025

When calling getEvents, a blob with the information of all the snapshots is returned, something like the following :

[{"text":"Algorand","x":160,"y":236,"w":159,"h":40,"clear":false},{"text":"This application enables","x":80,"y":294,"w":320,"h":32,"clear":false},{"text":"signing transactions on the","x":61,"y":330,"w":357,"h":32,"clear":false},{"text":"Algorand network","x":123,"y":366,"w":234,"h":32,"clear":false},{"text":"Quit app","x":183,"y":538,"w":114,"h":32,"clear":false},{"text":"Review Group ","x":122,"y":218,"w":248,"h":40,"clear":false},{"text":"Transaction","x":138,"y":258,"w":202,"h":40,"clear":false},{"text":"Transactions to review: 3","x":72,"y":316,"w":334,"h":32,"clear":false},{"text":"Swipe to review","x":135,"y":376,"w":210,"h":32,"clear":false}.......

Up until now, this served its purpose when looking for an Approve keyword such as "Hold To Sign", since we only expect one approve keyword per transaction.

For Algorand's transaction Group though, multiple transactions are processed in batch, meaning there are multiple "Hold To Sign" screens. This means that we need to distinguish between the snapshots we have already visited and the ones we have not.

This PR tracks adds tracking for the events that have already been searched, so that only one iteration per event takes place.

🔗 zboto Link

@0xPxt 0xPxt closed this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants