Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed
->sortByMeta
was not working properly in an application where the model has a custom morph map, so here is the fix!Test suite all green
OK (244 tests, 1891 assertions)
New test:
\Zoha\Meta\Tests\Clauses\TestCustomMorphMapOrderBy
New helper method to replace the
owner_type
from thefakeDataMeta
array, looks a little clumsy but it is the way I managed to get a failing test without rewriting the whole seeder.Not sure if I should push
.phpunit.result.cache
, so I didn't