Implement three trace APIs #2205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- trace_block - trace_filter - trace_transaction Plus tests and docs
|
Bencher Report| Branch | max/feature/trace_apis_batch_1 |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| full-blocks-erc20-transfers/full-blocks-erc20-transfers | 📈 view plot 🚷 view threshold | 1,188.10 (-14.48%) | 1,832.32 (64.84%) |
| full-blocks-evm-transfers/full-blocks-evm-transfers | 📈 view plot 🚷 view threshold | 553.68 (-9.56%) | 695.38 (79.62%) |
| full-blocks-zil-transfers/full-blocks-zil-transfers | 📈 view plot 🚷 view threshold | 3,552.00 (-15.88%) | 5,385.11 (65.96%) |
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 8.39 (-7.48%) | 10.43 (80.49%) |
JamesHinshelwood
previously approved these changes
Jan 24, 2025
zilliqa/src/api/trace.rs
Outdated
Comment on lines
274
to
275
| .skip(after as usize) | ||
| .take(count as usize) |
There was a problem hiding this comment.
Isn't it wasteful to only use these parameters after you've already collected all_traces? Should we use them above? Or equivalently, make all_traces an Iterator which you collect the correct number of here?
There was a problem hiding this comment.
Done, good point. I did a procedural approach here and used a loop label here because that was the smaller change from what we already had, but it feels a bit gnarly to me so I'm very open to switching to the iterator approach if you'd prefer?
- Moved pagination earlier in the code to avoid unnecessary traces - I've taken a procedural approach here with use of a loop label, but I'm open to switching to iterators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus tests and docs
Closes #2117
Closes #2192
Closes #2197