Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactor sync out of block_store.rs #2089

Draft
wants to merge 58 commits into
base: main
Choose a base branch
from

Conversation

shawn-zil
Copy link
Contributor

@shawn-zil shawn-zil commented Jan 6, 2025

This PR attempts to take the block syncing feature out of block_store.rs.

It performs syncing using a 3-phase mechanism:

  1. Build an in-memory chain history.
  2. Fetches the proposals for this chain history and injects them into the pipeline.
  3. Injects the latest proposals into the pipeline.

It is working on the local docker cluster - a new node is able to sync from genesis, and sync from elsewhere in history.

TODOs include:

  1. more checks;
  2. removal of the (now unused) portion from block_store.rs.

zilliqa/src/node.rs Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Jan 6, 2025

🐰 Bencher Report

Branch2039-refactor-blockstore
Testbedself-hosted
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)
Upper Boundary
milliseconds (ms)
(Limit %)
process-empty/process-empty📈 view plot
🚷 view threshold
8.40
(-8.17%)
10.35
(81.23%)
produce-full/produce-full📈 view plot
🚷 view threshold
1,725.90
(-12.36%)
2,315.19
(74.55%)
🐰 View full continuous benchmarking report in Bencher

@shawn-zil shawn-zil force-pushed the 2039-refactor-blockstore branch 7 times, most recently from 347a91c to ebc2258 Compare January 9, 2025 13:16
@shawn-zil shawn-zil force-pushed the 2039-refactor-blockstore branch from e5482f3 to 6768786 Compare January 10, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants