This repository has been archived by the owner on Jun 29, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Patch Kaya RPC to work with latest zilliqa-js #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fig files during error
iantanwx
approved these changes
Dec 6, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor comments, which are not critical.
const pk = zilliqa.util.generatePrivateKey(); | ||
const address = zilliqa.util.getAddressFromPrivateKey(pk); | ||
const pk = zCrypto.generatePrivateKey(); | ||
const address = zCrypto.getAddressFromPrivateKey(pk); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, @zilliqa-js/account
supports BIP-39. I suggest you use the Wallet
class in conjunction with a passphrase to generate these accounts, as that makes it repeatable between runs of kaya
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logged this as an issue. Will work on it next time. #64
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
zilliqa-js 0.2.x
. Compatibility with zilliqa-js 0.2.0 #60CC: @evesnow91 @mickys @bobio2018
Review Suggestion
Run
test/scripts/TestBlockchain.js
to verify that the solution worksStatus
Implementation