Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix share calculation and increase / decrease deposit on staking / unstaking #3

Merged
merged 16 commits into from
Oct 24, 2024

Conversation

DrZoltanFazekas
Copy link
Contributor

@DrZoltanFazekas DrZoltanFazekas commented Oct 18, 2024

This is the first working version that was run on the devnet and tested manually. The current tests help analyze the impact of various deposit sizes, stake sizes etc. on the staking APR. Unit tests will be added soon.

@DrZoltanFazekas DrZoltanFazekas requested a review from 86667 October 22, 2024 16:11
Copy link

@86667 86667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Would you mind adding some instruction for finding BLS public key, the peer id and the BLS signature of your node in order to generate the relevant sigs which activate yourself as validator?

src/DelegationV2.sol Show resolved Hide resolved
src/DelegationV2.sol Show resolved Hide resolved
@DrZoltanFazekas DrZoltanFazekas requested a review from 86667 October 24, 2024 08:22
@DrZoltanFazekas DrZoltanFazekas merged commit f0cfcb6 into main Oct 24, 2024
2 checks passed
@DrZoltanFazekas DrZoltanFazekas deleted the fix-share-calculation branch October 24, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants