feat: deposit_v4 with cheaper depositTopUp #29
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the work done by
updateLatestComputedEpoch()
to minimise gas cost ofdepositTopUp()
.To view diff with
deposit_v3
eg:Results
Gas costs before:
1st top up owner 1: Gas used 341943
1st top up owner 2: Gas used 16149
Rolling ahead 1 epoch
2nd top up owner 1: Gas used 111502
2nd top up owner 2: Gas used 16149
Rolling ahead a 2 epochs
3rd top up owner 1: Gas used 205615
3rd top up owner 2: Gas used 16158
After:
1st top up owner 1: Gas used 262857
1st top up owner 2: Gas used 16149
Rolling ahead 1 epoch
2nd top up owner 1: Gas used 27168
2nd top up owner 2: Gas used 16149
Rolling ahead a 2 epochs
3rd top up owner 1: Gas used 36947
3rd top up owner 2: Gas used 16158
Showing that it costs ~120_000 gas per new key added and is charged to whoever is first to call
deposit()
,unstake()
ordepositTopUp()
AFTER a deposit is made and one epoch has passed. If 2 or more epochs pass and none of those fns are called, then the next to call them must pay to write the new key into 2 committees, meaning a cost of ~240_000 gas.Outstanding TODO
First TopUp pays for writing of
stakerKeys
for inititial deposits.