Skip to content

Commit

Permalink
Minor fixes requested by the reviewer
Browse files Browse the repository at this point in the history
  • Loading branch information
DrZoltanFazekas committed Dec 18, 2024
1 parent 0f49ee7 commit f86ecce
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ cast send --legacy --value 10000000ether --rpc-url http://localhost:4201 --priva
```
with the BLS public key, the peer id and the BLS signature of your node. Note that the peer id must be converted from base58 to hexadecimal format and you must provide the delegation contract address when generating the BLS signature:
```bash
echo '{"secret_key":"...", "chain_id":..., "address":"0x7a0b7e6d24ede78260c9ddbd98e828b0e11a8ea2"}' | cargo run --bin convert-key
echo '{"secret_key":"...", "chain_id":..., "control_address":"0x7a0b7e6d24ede78260c9ddbd98e828b0e11a8ea2"}' | cargo run --bin convert-key
```
Make sure your node is fully synced before you run the above command.

Expand Down
3 changes: 2 additions & 1 deletion src/BaseDelegation.sol
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,8 @@ abstract contract BaseDelegation is IDelegation, PausableUpgradeable, Ownable2St
uint256 firstPending = index;
claims = new uint256[2][](fifo.last - index);
while (fifo.notReady(index)) {
claims[index - firstPending] = [fifo.items[index].blockNumber, fifo.items[index].amount];
WithdrawalQueue.Item storage item = fifo.items[index];
claims[index - firstPending] = [item.blockNumber, item.amount];
index++;
}
}
Expand Down

0 comments on commit f86ecce

Please sign in to comment.