Fix split workflow when no comments can be posted #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwrsandman
changed the title
review does not create a clang-tidy-review-output.json but the rest of the workflow expects the file to be created even if there are no comments. This causes cp or mv operations to fail and the post portion of the workflow fails trying to open an expected file. This change makes sure the output is created even if there is nothing to report. The body also serves to debug why there are no comments.
bwrsandman
force-pushed
the
multi-split-review-empty
branch
from
3bba35b to
f7a179e
Compare
There is an edge case in split workflow where the `review` does not create a `clang-tidy-review-output.json` but the rest of the workflow expects the file to be created even if there are no comments. This causes `cp` or `mv` operations to fail and the `post` portion of the workflow fails trying to open an expected file. This change makes sure the output is created even if there is nothing to report. The body also serves to debug why there are no comments.
This prevents post from merging messages with no comments such as `clang-tidy found no files to check` with messages with comments.
bwrsandman
force-pushed
the
multi-split-review-empty
branch
from
f7a179e to
0b1bf4c
Compare
ZedThree
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an edge case in split workflow where the
reviewdoes not createa
clang-tidy-review-output.jsonbut the rest of the workflow expects thefile to be created even if there are no comments.
This causes
cpormvoperations to fail and thepostportion of theworkflow fails trying to open an expected file.
This change makes sure the output is created even if there is nothing to
report. The body also serves to debug why there are no comments.