Check passwords using haveibeenpwned.com API #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeckie
requested changes
Oct 31, 2022
There was a problem hiding this comment.
This is a great idea, thanks for contributing.
Some people however might be a bit hesitant to send even a partial hash externally. I think there should be a Yes/No configuration (in proxyauth.config.Configuration) to control this new feature.
BTW, It looks like you're cutting it a bit fine for Hacktoberfest cutoff.
| private static final String API_URL = "https://api.pwnedpasswords.com/range/"; | ||
|
|
||
|
|
||
| private int check() throws IOException, NoSuchAlgorithmException { |
There was a problem hiding this comment.
Are you able to add a unit test for this?
Comment on lines
+91
to
+92
| if (line.substring(0, 35).equals(hash.substring(5))) { | ||
| String count = line.substring(36); |
There was a problem hiding this comment.
It would be great if you could add some comments, eg to clarify what those indices are for
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check passwords using haveibeenpwned.com API, to warn user if password is known from a data breach