Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc): Use jsonrpsee in zebra-node-services #9151

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

oxarbitrage
Copy link
Contributor

Motivation

In #9059 we replaced jsonrpc-* crates in the zebra-rpc module. However there is still a small use case of the deprecated library in the zebra-node-services crate that we will want to upgrade too.

Solution

  • Upgrade zebra-nodes-services to use jsonrpsee-types instead.
  • Make other small cleanps.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@oxarbitrage oxarbitrage requested review from a team as code owners January 20, 2025 18:34
@oxarbitrage oxarbitrage requested review from upbqdn and removed request for a team January 20, 2025 18:34
@oxarbitrage oxarbitrage self-assigned this Jan 20, 2025
@oxarbitrage oxarbitrage added C-cleanup Category: This is a cleanup A-rpc Area: Remote Procedure Call interfaces P-Low ❄️ labels Jan 20, 2025
upbqdn
upbqdn previously approved these changes Jan 20, 2025
@mergify mergify bot merged commit c103c2d into main Jan 20, 2025
145 checks passed
@mergify mergify bot deleted the replace-to-jsonrpsee-zebra-nodes-services branch January 20, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Area: Remote Procedure Call interfaces C-cleanup Category: This is a cleanup P-Low ❄️
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants