-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respond to getblockchaininfo with genesis block when empty state #9138
Respond to getblockchaininfo with genesis block when empty state #9138
Conversation
…t fails. Adds test in prop.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, thank you for making it. There are a few non used imports that need to be fixed. I also left some small optional suggestions in the test code.
…es reference and tokio pause() call
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks:
You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
@mergify requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Motivation
A lightwalletd test fails for getblockchaininfo when the state is empty. This PR refactors the rpc request to return the genesis block.
Specifications & References
Solution
Adds a test for returning the genesis state in prop.rs. Refactors getblockchaininfo rpc to return the genesis block if TipPoolValues request fails.
Tests
Follow-up Work
PR Author's Checklist
PR Reviewer's Checklist