-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "ref(workflow): move most scripts to their own executables" #8132
Conversation
)" This reverts commit d85b010.
If this CI passes without errors, we can merge this PR. We need to manually scroll down and check it for errors, because they don't reliably show up in the CI summary or auto-opened tickets: |
That worked, and I manually checked all of the other CI runs for this PR, they also passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing it this way would revert improvements made to workflows that are not failing. From the 15+ impacted workflow files here, 1 workflow is failing. I'd prefer to tackle this specific issue and not revert the whole PR. I'll prioritize this
My goal was restoring test coverage as reliably and quickly as possible. This PR does that. If we merge this PR, then the rest of the team doesn't need to worry about this bug, and you can take whatever time you need to fix the bugs in that workflow and its sub-workflows. So I'd prefer a quick solution that makes all workflows functional. We can always add back the improvements when they are working correctly. Would you be ok with reverting the changes to |
The odd thing here is that those failures are not being reflected in PR or main checks As far as I've been able to identify the workflow is getting a failure, but all jobs are ending successfully (so the final check result is a successful run) even on the commit that opened the issue: d1e72c1
Yes, I'd be ok reverting the changes in |
Ok, happy to leave the fix or the partial revert to you. |
We don't need reminders for this, we're still deciding how to fix it. |
Motivation
CI has been failing with an internal GitHub error since PR #8005 merged. Since people are away, the simplest way to fix this is to revert it for now.
Reverts #8005
Close #8123