Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(shielded-scan) Improve feature docs #8114

Merged
merged 5 commits into from
Dec 21, 2023
Merged

docs(shielded-scan) Improve feature docs #8114

merged 5 commits into from
Dec 21, 2023

Conversation

oxarbitrage
Copy link
Contributor

Motivation

Improve documentation for the shielded-scan feature.

Close #8049 and close #8046

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

Solution

Improve documentation.

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

@oxarbitrage oxarbitrage added A-docs Area: Documentation P-Medium ⚡ A-blockchain-scanner Area: Blockchain scanner of shielded transactions labels Dec 16, 2023
@oxarbitrage oxarbitrage requested a review from a team as a code owner December 16, 2023 21:42
@oxarbitrage oxarbitrage requested review from upbqdn and removed request for a team December 16, 2023 21:42
@oxarbitrage oxarbitrage self-assigned this Dec 16, 2023
@github-actions github-actions bot added the C-feature Category: New features label Dec 16, 2023
@oxarbitrage oxarbitrage mentioned this pull request Dec 16, 2023
Closed
teor2345
teor2345 previously approved these changes Dec 17, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few tweaks to answer common questions or make it easier to read.

book/src/user/shielded-scan.md Outdated Show resolved Hide resolved
book/src/user/shielded-scan.md Show resolved Hide resolved
book/src/user/shielded-scan.md Outdated Show resolved Hide resolved
upbqdn
upbqdn approved these changes Dec 21, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
book/src/user/shielded-scan.md Outdated Show resolved Hide resolved
book/src/user/shielded-scan.md Outdated Show resolved Hide resolved
upbqdn
upbqdn previously approved these changes Dec 21, 2023
View reviewed changes
book/src/user/shielded-scan.md Outdated Show resolved Hide resolved
@mergify mergify bot merged commit d1e72c1 into main Dec 21, 2023
154 checks passed
@mergify mergify bot deleted the issue8049 branch December 21, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upbqdn upbqdn upbqdn approved these changes

@teor2345 teor2345 teor2345 left review comments

Assignees

@oxarbitrage oxarbitrage

Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions A-docs Area: Documentation C-feature Category: New features
Projects
None yet
Milestone
No milestone
3 participants
@oxarbitrage @upbqdn @teor2345