Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump what we can from the production group #7996

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Conversation

oxarbitrage
Copy link
Contributor

@oxarbitrage oxarbitrage commented Nov 26, 2023

Motivation

We have #7966 where the group prod is bumped however, we can't upgrade the hyper version in zebra-rpc and zebrad because an upgraded version without more research and bigger modifications to our code.

Here i am upgrading all the rest we can while opening a ticket to deal with the hyper upgrade separated.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

Solution

Upgrade what we can, partially replace #7966

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

@oxarbitrage oxarbitrage added A-dependencies Area: Dependency file updates A-rpc Area: Remote Procedure Call interfaces labels Nov 26, 2023
@oxarbitrage oxarbitrage self-assigned this Nov 26, 2023
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Nov 26, 2023
@oxarbitrage oxarbitrage changed the title bump(deps): Upgrade what we can from the production group build(deps): Bump what we can from the production group Nov 26, 2023
@oxarbitrage oxarbitrage marked this pull request as ready for review November 26, 2023 19:58
@oxarbitrage oxarbitrage requested review from a team as code owners November 26, 2023 19:58
@oxarbitrage oxarbitrage requested review from teor2345 and removed request for a team November 26, 2023 19:58
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

mergify bot added a commit that referenced this pull request Nov 27, 2023
@mergify mergify bot merged commit 681ae68 into main Nov 27, 2023
137 checks passed
@mergify mergify bot deleted the bump-prod-group branch November 27, 2023 03:26
@arya2 arya2 mentioned this pull request Nov 29, 2023
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates A-rpc Area: Remote Procedure Call interfaces C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants