Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import from JSR #88

Closed
wants to merge 3 commits into from
Closed

Import from JSR #88

wants to merge 3 commits into from

Conversation

emrahcom
Copy link
Contributor

@emrahcom emrahcom commented Aug 9, 2024

This PR:

  • Updates @std/encoding's version tag.
    JSR supports 0.224.0 as tag to be backward compatible but new tag is started from 1.0.0 and the current one is 1.0.1.

  • Imports packages from JSR in tests.

  • Imports packages from JSR in examples.

See

@timonson
Copy link
Member

timonson commented Aug 9, 2024

Thank you @emrahcom . What are the advantages and disadvantaes here?

@emrahcom
Copy link
Contributor Author

emrahcom commented Aug 9, 2024

The standard packages will be updated in JSR. https://deno.land/std will not be updated anymore.
See this post for more details.

And tests will be more acqurate if they use the same packages.

@timonson
Copy link
Member

timonson commented Aug 9, 2024

I will not merge it, because I want the deps to be available inside the browser.

@timonson timonson closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants