Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: Replace the default middleware list by the 'web' middleware group #207

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

Voltra
Copy link
Collaborator

@Voltra Voltra commented Jan 7, 2025

The filament-fabricator.middleware config option's default value was the exhaustive array of middlewares used for the web middleware group/alias (with \Illuminate\Session\Middleware\AuthenticateSession::class added commented in the middle).

This PR proposes to replace the new default with simply an array containing only the 'web' middleware group, effectively achievement the same results (for most use cases) without having to maintain two middleware stacks (one in the app's kernel, the other in this package's config).

Users cans still modify the middleware stack to suit their needs should they need to.

@Voltra Voltra requested a review from Z3d0X January 7, 2025 21:03
@Voltra Voltra self-assigned this Jan 7, 2025
Copy link

what-the-diff bot commented Jan 7, 2025

PR Summary

  • Simplified Middleware Management
    In the past, developers had to manage multiple middleware classes separately for the filament-fabricator. This proved to be quite a hassle when maintaining the code. With this update, we have now replaced those individual middleware classes with just one entry denoted by 'web'. This streamlines and simplifies overall code management.

@Z3d0X Z3d0X merged commit 0531657 into Z3d0X:2.x Jan 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants