Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in [main.instance.instance_expose_suspended_web] #68

Closed
wants to merge 1 commit into from
Closed

Fix typo in [main.instance.instance_expose_suspended_web] #68

wants to merge 1 commit into from

Conversation

ericgeldmacher
Copy link
Contributor

@ericgeldmacher ericgeldmacher commented Feb 21, 2023

Fix Config panel question 'instance_expose_suspended_web' should be initialized with a value during install or upgrade. error.

Problem

Encounter an error when accessing gotosocial config in the admin panel

Solution

changing _ in config_panel.toml#L251

bind = "instance-expose-suspended_web:__FINALPATH__/config.yaml"

to a - fixed the issue

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

(manually making changes on the live system fixed the issue)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)
Screen Shot 2023-02-21 at 3 26 44 PM

Fix `Config panel question 'instance_expose_suspended_web' should be initialized with a value during install or upgrade.` error.
@OniriCorpe
Copy link
Member

ah, I put the correction in testing 2 minutes before your PR :")

I also asked for the CI to test config panels so that it doesn't happen again
YunoHost/package_check#140

thank you ^w^

@OniriCorpe OniriCorpe closed this Feb 21, 2023
@OniriCorpe
Copy link
Member

okay the fix should be available tomorrow :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants