Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong poll #7

Merged
merged 2 commits into from
May 2, 2024
Merged

Wrong poll #7

merged 2 commits into from
May 2, 2024

Conversation

oiseauroch
Copy link
Collaborator

Problem

  • try to fix Wrong poll URL #6 Didn't try for now but may work on it in the future then make pr upstream. Feel free to contribute without asking me !

Solution

  • patch with new env variable for base domain url. Could be more pertinent to use full URL with sheme.

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Please, try it locally before triggering ci !

@limaanto
Copy link
Collaborator

limaanto commented May 2, 2024

Hey thanks for the contribution! I cleaned the patch file that contained lots of unwanted modifications to yarn.lock
Now, on to testing it

@limaanto
Copy link
Collaborator

limaanto commented May 2, 2024

It took a few attempts because I'm not goot at JS, but it now works! I'm merging 👌

@limaanto limaanto merged commit 82f045e into testing May 2, 2024
@limaanto limaanto deleted the wrong_poll branch May 2, 2024 21:17
@limaanto limaanto mentioned this pull request May 2, 2024
Closed
@orhtej2
Copy link

orhtej2 commented May 2, 2024

Amazing work, hope it gets obsolete once GRA0007/crab.fit#329 lands 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oiseauroch @limaanto @orhtej2