Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Add run-test.mk to clean #4880

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

KrystalDelusion
Copy link
Member

What are the reasons/motivation for this change?

If a test directory already contains a run-test.mk file it won't regenerate if anything in the directory changes, meaning any files will be skipped and any removed tests will raise an error because of the missing file.

Explain how this is achieved.

MK_TEST_DIRS provides a list of directories that generate run-test.mk files, so we can use that list in the clean target to delete them; thus allowing future runs of make test to correctly regenerate the needed file.

If applicable, please suggest to reviewers how they can test the change.

make tests/techmap/run-test.mk
rm tests/techmap/abc9.ys
clean
make makefile-tests/tests/techmap

Without this change, the second call to make will raise an error due to the missing abc9.ys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant