hashlib: merge hash_ops with hash_top_ops for plugin compat #4849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
povik
reviewed
Jan 20, 2025
| }; | ||
| // Boilerplate compressor for trivially implementing | ||
| // top-level hash method with hash_into | ||
| #define HASH_TOP_LOOP_FST [[nodiscard]] static inline Hasher hash |
There was a problem hiding this comment.
Why not put all of the function into one macro, so that you would write e.g. DEFAULT_HASH_TOP(std::pair<P, Q> a) to use it?
There was a problem hiding this comment.
I tried doing this the simplest possible way I could think of, passing a type into a macro argument, and it wasn't valid preprocessor code for some reason. We can change this later
kernel/hashlib.h
Outdated
| @@ -245,6 +239,11 @@ struct hash_cstr_ops { | |||
| h.hash32(*(a++)); | |||
| return h; | |||
| } | |||
| [[nodiscard]] static inline Hasher hash(const char *a) { | |||
There was a problem hiding this comment.
instead of calling the polymorphic h.eat(...) we explicitly call the hash_into method of self
There was a problem hiding this comment.
as for why we do that, it's because I'm paranoid about pointer conversions
There was a problem hiding this comment.
Can't we use hash_into in the macro helper?
nakengelhardt
added
the
merge-before-release
povik
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing #4524 I made it so that a type can have an implementation for how to hash a single instance (
hash_top_ops) distinct from one for how to hash an instance in the context of an on-going context (hash_ops). This PR implements @povik's idea to merge them together so that plugin code can still explicitly passhash_ptr_opsinto associative data structures likedict.docs/source/yosys_internals/hashing.rstto match