proc_dff: fix early return bug #4714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* early return caused proc_dff to stop considering rules after seeing one async rule - this is because continue should have been used to continue to procecssing the next rule instead of returning from the function
widlarizer
approved these changes
Nov 8, 2024
|
@widlarizer is this good to merge? |
|
Yep, it is. Just to clarify, at least from me, an approval + green CI means that the PR author is free to merge it. I don't like to merge PRs I'm revieweing since the authors might still have something to add or fix. @georgerennie you can go ahead and merge these whenever |
I don't have write access to Yosys so I need someone else to merge these. All of the ones you have approved I am happy to be merged - I don't have anything to add |
|
Oh, I didn't realize only maintainers get to merge even maintainer-approved PRs. My bad, just used to a diff setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4712 which is a bug introduced in #4569, where multiple rules in processes were not being considered if an asynchronous one was encountered as the code erroneously returned from the function instead of continuing the processing loop.