docs: avoid concurrency issues when generating images in parallel #4632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/source/_images/Makefile
Outdated
| @@ -31,14 +31,13 @@ all_tex: $(TEX_FILES:.tex=.pdf) $(TEX_FILES:.tex=.svg) | |||
|
|
|||
| %.pdf: %.tex | |||
| cd $(@D) && $(FAKETIME) pdflatex $(<F) --interaction=nonstopmode | |||
| rm -f $(*).aux $(*).log | |||
There was a problem hiding this comment.
I think the rm was there because of how the docs website was being done and is no longer necessary. It would be better to leave this out entirely and just rely on the gitignore instead of removing the log files.
- remove the tidy target from the main target. * aux/log file are already excluded in a .gititgnore file * allow parallel generation as the tidy target imposes sequential build
|
I have reverted my previous commit and just removed the |
Add `$(TARGETS)` for gen_examples and gen_images since they need the `yosys` executable. Add guidelines source files as a prerequisite to docs/source/generated while we're at it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve issue #4631 when building the doc images in parallel.
I have removed the
tidytarget and I just delete log and aux file after building each pdf.