Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump abc submodule #4628

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Bump abc submodule #4628

merged 1 commit into from
Oct 7, 2024

Conversation

povik
Copy link
Member

@povik povik commented Oct 3, 2024

What are the reasons/motivation for this change?

Pulling in berkeley-abc/abc#327; any upstream fixes

@povik
Copy link
Member Author

povik commented Oct 3, 2024

The CI failure for nix is because abc now wants to pull a googletest dependency from the internet when doing a cmake build but the nix sandbox denies internet access. Cc @widlarizer

@widlarizer
Copy link
Collaborator

This isn't a submodule bump, it's switching abc branches away from yosys-experimental. The nix breakage is happening because this PR removes a gtest revert commit that's present on yosys-experimental. I can't track down what this commit even is, since it differs from both possible sources so much:

emil@fridge ~/p/abc (upstream)> git diff --stat 745ea92718c4c861eb08d0120ce1b99805e16839 upstream | tail -n 1
 145 files changed, 814 insertions(+), 9076 deletions(-)
emil@fridge ~/p/abc (upstream)> git diff --stat 745ea92718c4c861eb08d0120ce1b99805e16839 yosys-experimental | tail -n 1
 51 files changed, 348 insertions(+), 3726 deletions(-)

@povik
Copy link
Member Author

povik commented Oct 5, 2024

This isn't a submodule bump, it's switching abc branches away from yosys-experimental.

This is a bump from 2188bc7 to 745ea92, which is a merge of 2188bc7 and upstream head. I pushed the merge to yosys-experimental for your benefit now.

I can't track down what this commit even is, since it differs from both possible sources so much:

This is what you get in a merge commit...

@povik povik merged commit 0556cb5 into YosysHQ:main Oct 7, 2024
22 checks passed
@povik povik deleted the bump-abc branch October 7, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants