Slight optimization of LRU #.setpop

Yomguithereal · Dec 21, 2023 · 8453d82 · 8453d82
1 parent f7563f4
commit 8453d82
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.39.7 (provisional)
+
+* Slight performance optimization of LRU classes `#.setpop` method.
+
 ## 0.39.6
 
 * Fixing type declarations of `FibonacciHeap`, `StaticIntervalTree` & `Vector` (@Macil).

diff --git a/lru-cache-with-delete.js b/lru-cache-with-delete.js
@@ -142,7 +142,7 @@ LRUCacheWithDelete.prototype.setpop = function(key, value) {
     this.tail = this.backward[pointer];
     oldValue = this.V[pointer];
     oldKey = this.K[pointer];
-    delete this.items[this.K[pointer]];
+    delete this.items[oldKey];
   }
 
   // Storing key & value

diff --git a/lru-cache.js b/lru-cache.js
@@ -177,7 +177,7 @@ LRUCache.prototype.setpop = function(key, value) {
     this.tail = this.backward[pointer];
     oldValue = this.V[pointer];
     oldKey = this.K[pointer];
-    delete this.items[this.K[pointer]];
+    delete this.items[oldKey];
   }
 
   // Storing key & value

diff --git a/lru-map-with-delete.js b/lru-map-with-delete.js
@@ -142,7 +142,7 @@ LRUMapWithDelete.prototype.setpop = function(key, value) {
     this.tail = this.backward[pointer];
     oldValue = this.V[pointer];
     oldKey = this.K[pointer];
-    this.items.delete(this.K[pointer]);
+    this.items.delete(oldKey);
   }
 
   // Storing key & value

diff --git a/lru-map.js b/lru-map.js
@@ -137,7 +137,7 @@ LRUMap.prototype.setpop = function(key, value) {
     this.tail = this.backward[pointer];
     oldValue = this.V[pointer];
     oldKey = this.K[pointer];
-    this.items.delete(this.K[pointer]);
+    this.items.delete(oldKey);
   }
 
   // Storing key & value