Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logic that caused fail error when download log files #216

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Remove logic that caused fail error when download log files #216

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88616ad
Removed logic that causes error fail when downloading log files
sihammill Feb 11, 2025
464df04
Merge branch 'si-tf_compare_dev' of https://github.com/YoYoGames/GM-T…
sihammill Feb 11, 2025
4854375
Merge branch 'develop' into si-tf_compare_dev
ksuchitra532 Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions tf_compare.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,6 @@ def get_workflow_runs():
print(f"Error deleting folder {folder_to_delete}: {e}")
else:
print("Failed to fetch logs:", response.text)
else:
sys.exit("Failed to get details from current runtime") # Print error details
get_artifact_URL()
else:
print("Valid workflow not used, only Beta, Monthly or Red on the develop branch is accepted for the TF Compare script")
Expand All @@ -138,8 +136,6 @@ def unzip_log_files():
# Get list of filenames in zipfile
zip_files = zip_ref.namelist()

print(zip_files)

# Only unzip the Testing log file whihc contains the RT verison
#log_files = [f for f in zip_files if f.startswith("CI/4_Testing")]
log_files = [f for f in zip_files if fnmatch.fnmatch(f, "CI/*Testing*")]
Expand Down Expand Up @@ -615,7 +611,7 @@ def log_fail(testName, failDetails, compiler, test_code_details):
f"{test_code_details[1]}\n\n"
f"### Which platform(s) are you seeing the problem on?\n"
f"Windows",
"assignee" : "sihammill"
#"assignee" : "username"
}
else:
issue_data = {
Expand Down
Loading