Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies version #246

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

remia
Copy link
Collaborator

@remia remia commented Feb 1, 2024

Updating lxml yielded this new error related to the DCSubtitle.xsd schema: Schema validation error : local complex type: The content model is not determinist., line 39.

It seems this is related to https://github.com/Ymagis/ClairMeta/pull/36/files so tagging @matmat if you have more thoughts. The current change seem to fix the immediate issue but I have to admit it may need more careful thinking, my XSD speak is rusty.

@jamiegau
Copy link
Contributor

jamiegau commented Feb 1, 2024

Um. the first thing that pops into my head..
DCSubtitle.xsd was updated..
the newer lxml cracks an error over the current lxml lib. But is better in other aspects.

Am I right in thinking, either the newer DCSubtitle.xsd has an issue or the current lxml has an issue? Would that be the conclusion?

@remia
Copy link
Collaborator Author

remia commented Feb 3, 2024

I tend to think it was an issue in our DCSubtitle.xsd schema as the SubtitleType was extending the FontTypeSubtitleLevel type with an additional Text element, but looking at FontTypeSubtitleLevel, it already has the same Text element included. The nesting structure is rather complex as per specifications, I tried to check this change with some test Subtitle XML and different variations of Text / Font elements but it seems to work so far.

@matmat
Copy link
Contributor

matmat commented Feb 3, 2024

I think the xsd is wrong and needs to be updated. I will try to look into it soon but I am extremely busy atm :/

@jamiegau
Copy link
Contributor

jamiegau commented Feb 3, 2024

If an issue does exist in the xsd file, please do get a comment on this so we can send it to SMPTE for review and rectification.

I'll be monitoring this ticket for this possibility.

@remia
Copy link
Collaborator Author

remia commented Feb 4, 2024

@jamiegau This should be only for Interop subtitle which have no official schema that I am aware of.

@matmat Thanks, appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants