J2C validation from RDD 52 Compatibility Note 1 #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you considered using a submodule to track the versions of the code? I could also create releases on PyPI. |
|
@palemieux Good point, a submodule would indeed be better, I'll update the PR later. PyPI would be nice and simpler to deal with but maybe a bit too early if the issue is still under active work? Thanks! |
I agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion with @jamiegau and report from SMPTE/rdd52#8, this PR adds an example implementation of the check from https://github.com/sandflow/note-1-validator (assuming the license allow us including the code but will not merge unless confirmed). As the issue is still under active research, not planning on merging this in the short term in any case. Note that to this will only work on unencrypted DCPs or encrypted DCP for which you provide both KDM and Private key to ClairMeta (which I don't expect to be possible for most cases).
Tagging @palemieux for visibility.