Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mathematicalmichael committed Nov 26, 2024
1 parent 42a630b commit 18bb8ad
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions source/pacmap/pacmap.py
Original file line number Diff line number Diff line change
Expand Up @@ -871,9 +871,10 @@ def __init__(self,

if self.n_components < 1:
raise ValueError(
"The number of projection dimensions must be at least 2.")
if self.n_components == 1:
logger.warning('Warning: Defaults were chosen around dimension 2. Dimension 1 has not been tested.')
"The number of projection dimensions must be at least 1."
)
if self.n_components != 2:
logger.debug("Note: `n_components != 2` have not been thoroughly tested.")
if self.lr <= 0:
raise ValueError("The learning rate must be larger than 0.")
if self.distance == "hamming" and apply_pca:
Expand Down

0 comments on commit 18bb8ad

Please sign in to comment.