Fan Speed fix for Air Purifier Pro #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bug fix for Air Purifier Pro Adjusting the FAN SPEED in MANUAL mode in the Home App, the FAN SPEED slider has values from 0-100. This plugin translates the slider setting to a number between 0 and 10, so sending out this parsed value to the air purifier. I assume the reason is that other Xiaomi Air Purifiers using fan speed settings from 0 - 10. However, Air Purifier Pro supports 17 different values for the FAN SPEED (in Mi App the minimum setting is 7~12m2 and the maximum is 35~60m2). All together there are 17 different values available. Because the plugin limit is 10, so the maximum FAN SPEED setting stops around ~60%. When the plugin checks for the actual fan speed to adjust the slider position, the same incorrect calculation results in setting the slider to the lower range instead of the actual speed. I used a different formula to translate the slider setting to a value between 1 and 17.
|
Hello @YinHangCode could you please review and merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix for Air Purifier Pro
Adjusting the FAN SPEED in MANUAL mode in the Home App, the FAN SPEED slider has values from 0-100. This plugin translates the slider setting to a number between 0 and 10, so sending out this parsed value to the air purifier. I assume the reason is that other Xiaomi Air Purifiers using fan speed settings from 0 - 10. However, Air Purifier Pro supports 17 different values for the FAN SPEED (in Mi App the minimum setting is 7-12m2 and the maximum is 35-60m2). All together there are 17 different values available. Because the plugin limit is 10, so the maximum FAN SPEED setting stops around ~60%. When the plugin checks for the actual fan speed to adjust the slider position, the same incorrect calculation results in setting the slider to the lower range instead of the actual speed.
I used a different formula to translate the slider setting to a value between 1 and 17.