QIXUAN TASK1 2 4 #433
Closed
QIXUAN TASK1 2 4 #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huangwux
requested review from
LazyJazz,
sshockwave,
qinchuanhui and
huanchenz
as code owners
qinchuanhui
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In units :
QXTank1 is for task2 (only copies a tiny_tank)
DisTank is for task4 (issue #368 )
QHCritTank is for task4 (issue #357 ) (cooperating with 黄文杰)
In bullets :
RangeBall is for task4 (issue #413 )
RandomBall is for task4(issue #357 ) (cooperating with 黄文杰)
对于issue #357 ，齐轩通过随机算法，在bullets中加入了有特定暴击率的RandomBall，并在units中加入了相应的QHCritTank，黄文杰.通过宏定义ADD_SELECTABLE_CRIT_BULLET实现：引用同学们写的各种子弹并且.在打击目标周围生成了10个随机的子弹，速度都指向打击目标。
// 在最后一个commit "modify_qixuan"中，我把src/battle_game/core/CMakeLists.txt改成了初始的状态，然后在src/battle_game/core/bullets/rangeball.h中把对die_time_和now_time_的定义移动到了private中