Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish semantic and formatting changes in modules #277

Draft
wants to merge 28 commits into
base: develop
Choose a base branch
from

Conversation

bskqd
Copy link
Contributor

@bskqd bskqd commented Apr 19, 2023

Tests should pass after merging the PR because of some needed changes in the workflow, locally everything should pass correctly (but take changes in the workflow into account)

bskqd and others added 26 commits March 6, 2023 10:50
…_redis_on_populate' into override_compilation_results_in_redis_on_populate
…on' into distinguish_semantic_and_formatting_changes_in_modules
…on' into distinguish_semantic_and_formatting_changes_in_modules
…ic_and_formatting_changes_in_modules

# Conflicts:
#	tests/test_compile_modules.py
@bskqd bskqd temporarily deployed to tests April 19, 2023 08:32 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2023

Coverage report

Full coverage report summary (click to unfold) check_archived_drafts.py: 91%
create_config.py: 100%
extractors/__init__.py: 100%
extractors/draft_extractor.py: 67%
extractors/extract_elem.py: 77%
extractors/helper.py: 44%
figures_and_stats/__init__.py: 100%
figures_and_stats/yang_get_stats.py: 92%
ietf_modules_extraction/__init__.py: 100%
ietf_modules_extraction/gather_ietf_dependent_modules.py: 81%
ietf_modules_extraction/yang_version_1_1.py: 75%
job_log.py: 77%
main_page_generation/__init__.py: 100%
main_page_generation/private_page.py: 52%
message_factory/__init__.py: 100%
message_factory/message_factory.py: 26%
metadata_generators/__init__.py: 100%
metadata_generators/base_metadata_generator.py: 100%
metadata_generators/draft_metadata_generator.py: 100%
metadata_generators/example_metadata_generator.py: 100%
metadata_generators/extract_emails.py: 67%
metadata_generators/rfc_metadata_generator.py: 100%
modules_compilation/__init__.py: 100%
modules_compilation/compilation_status.py: 17%
modules_compilation/compile_modules.py: 87%
modules_compilation/file_hasher.py: 98%
modules_compilation/files_generator.py: 98%
parsers/__init__.py: 100%
parsers/confdc_parser.py: 70%
parsers/pyang_parser.py: 100%
parsers/yang_parser.py: 65%
parsers/yangdump_pro_parser.py: 91%
parsers/yanglint_parser.py: 91%
redis_connections/__init__.py: 100%
redis_connections/constants.py: 100%
redis_connections/redis_connection.py: 96%
redis_connections/redis_user_notifications_connection.py: 61%
rename_file_backup.py: 78%
tests/test_check_archived_drafts.py: 96%
tests/test_compile_modules.py: 98%
tests/test_extract_elem.py: 96%
tests/test_extract_emails.py: 94%
tests/test_file_hasher.py: 98%
tests/test_gather_ietf_dependent_modules.py: 98%
tests/test_get_stats.py: 97%
tests/test_private_page.py: 100%
tests/test_remove_directory_content.py: 98%
tests/test_rename_file_backup.py: 97%
tests/test_utility.py: 100%
tests/test_yang_version_1_1.py: 97%
utility/__init__.py: 100%
utility/static_variables.py: 100%
utility/utility.py: 86%
versions.py: 100%

The coverage rate went from 85.87% to 85.1% ⬇️

95.95% of new lines are covered.

Diff Coverage details (click to unfold)

modules_compilation/file_hasher.py

95.45% of new lines are covered (98.88% of the complete file).
Missing lines: 159

tests/test_compile_modules.py

96.96% of new lines are covered (98.66% of the complete file).
Missing lines: 182, 311

tests/test_get_stats.py

100% of new lines are covered (97.27% of the complete file).

modules_compilation/compile_modules.py

90% of new lines are covered (87.4% of the complete file).
Missing lines: 248

@bskqd bskqd temporarily deployed to tests April 19, 2023 15:12 — with GitHub Actions Inactive
…ic_and_formatting_changes_in_modules

# Conflicts:
#	.github/images/coverage.svg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants