Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Ignore Q000 in flake8 config #826

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

microamp
Copy link
Contributor

@microamp microamp commented Mar 5, 2024

Use single quotes for Python strings to fix the flake8 error.

./parseAndPopulate/modulesComplicatedAlgorithms.py:432:34: Q000 Double quotes found but single quotes preferred
Error: Process completed with exit code 1.

Update: flake8 doesn't seem to support black as profile, like isort does. Going forward, we'll choose black's formatting over flake8's when there is a conflict between the two.

@microamp
Copy link
Contributor Author

microamp commented Mar 5, 2024

Update: All checks now pass.

@microamp microamp requested a review from xorrkaz March 5, 2024 01:40
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.83%. Comparing base (8674bf5) to head (221a97f).
Report is 1 commits behind head on develop.

❗ Current head 221a97f differs from pull request most recent head 2181d15. Consider uploading reports for the commit 2181d15 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #826   +/-   ##
========================================
  Coverage    77.83%   77.83%           
========================================
  Files          112      112           
  Lines        11490    11490           
========================================
  Hits          8943     8943           
  Misses        2547     2547           
Files Coverage Δ
parseAndPopulate/modulesComplicatedAlgorithms.py 64.42% <0.00%> (ø)

@microamp microamp changed the title chore: Use single quotes for Python string to fix flake8 checker chore: Ignore Q000 in flake8 config Mar 5, 2024
@microamp microamp merged commit f6293ff into YangCatalog:develop Mar 5, 2024
4 of 5 checks passed
@microamp microamp deleted the chore/fix-flake8 branch March 5, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant