[70_9] Parser: improve number_parser and keyword_parser for S7 Scheme #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da-liii
changed the title
|
|
da-liii
commented
May 15, 2024
| read_keyword (string s, int& i, string& result, array<char> extras) { | ||
| int opos= i; | ||
| int s_N = N (s); | ||
| if (i < s_N && is_alpha (s[i])) i++; |
There was a problem hiding this comment.
a keyword must start with alpha
da-liii
commented
May 15, 2024
| !(s[pos] == '.' && pos + 1 < N (s) && is_digit (s[pos + 1]))) | ||
| return; | ||
|
|
||
| // Start with 0b, 0o, 0x | ||
| if (can_parse_prefix_0b (s, pos)) { | ||
| if (prefix_hash () && pos + 1 < N (s) && s[pos] == '#' && |
da-liii
commented
May 15, 2024
| else { | ||
| for (int j= 0; j < group_of_keywords_N; j++) { | ||
| string word= get_label (group_of_keywords[j]); | ||
| p_keyword_parser.put (utf8_to_cork (word), group); |
There was a problem hiding this comment.
when matching the keyword, string->number is actually string-<gtr>number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#prefixWhy
In S7 Scheme
How to test your changes?
Launch Mogan Research and check
TeXmacs/tests/tm/70_9.tm