Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[66_5] improve parsing speed of tm snippets #1636

Merged
merged 3 commits into from
Feb 3, 2024

Conversation

jingkaimori
Copy link
Contributor

Why you open this Pull Request?

improve parsing speed of tm snippets, which may take 1.5s when parsing a short document.

What work have you done in the current Pull Request?

  • use template to avoiding to look up settings repeatly

by avoiding to look up settings repeatly
@jingkaimori jingkaimori requested a review from da-liii February 3, 2024 08:57
@da-liii
Copy link
Contributor

da-liii commented Feb 3, 2024

With this pr on sicp.tm:

TeXmacs] std-bench, Task 'texmacs_to_tree' took 269 ms

without this pr on sicp.tm

TeXmacs] std-bench, Task 'texmacs_to_tree' took 3381 ms

@da-liii da-liii changed the title improve parsing speed of tm snippets [66_5] improve parsing speed of tm snippets Feb 3, 2024
Copy link
Contributor

@da-liii da-liii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@da-liii
Copy link
Contributor

da-liii commented Feb 3, 2024

The impl in 66_5 is actually wrong (because get_preference is expensive), that's why it is using the same task id.

@da-liii da-liii merged commit fc823db into branch-1.2 Feb 3, 2024
8 checks passed
@da-liii da-liii deleted the jk/unnumbered/tm-loading-improvement branch February 3, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants