[78_2] Gitee Scan Rule 025: Effective C++, item 30: understand the in…

…s and outs of inlining
XmacsLabs · Feb 5, 2024 · 867dc9a · 867dc9a
1 parent 6701218
commit 867dc9a
Show file tree

Hide file tree

Showing 18 changed files with 31 additions and 31 deletions.
diff --git a/src/Data/History/patch.hpp b/src/Data/History/patch.hpp
@@ -27,23 +27,23 @@ class patch;
 class patch_rep : public abstract_struct {
 public:
   inline patch_rep () {}
-  inline virtual ~patch_rep () {}
-  virtual int                 get_type ()= 0;
-  inline virtual int          get_arity () { return 0; }
-  inline virtual patch        get_child (int i);
-  inline virtual modification get_modification () {
+  virtual ~patch_rep () {}
+  virtual int          get_type ()= 0;
+  virtual int          get_arity () { return 0; }
+  virtual patch        get_child (int i);
+  virtual modification get_modification () {
     TM_FAILED ("not a modification");
     return mod_assign (path (), "");
   }
-  inline virtual modification get_inverse () {
+  virtual modification get_inverse () {
     TM_FAILED ("not a modification");
     return mod_assign (path (), "");
   }
-  inline virtual bool get_birth () {
+  virtual bool get_birth () {
     TM_FAILED ("not a birth");
     return false;
   }
-  inline virtual double get_author () { return -1; }
+  virtual double get_author () { return -1; }
 };
 
 class patch {

diff --git a/src/Edit/Editor/edit_main.hpp b/src/Edit/Editor/edit_main.hpp
@@ -43,7 +43,7 @@ class edit_main_rep : public edit_interface_rep,
 public:
   edit_main_rep (server_rep* sv, tm_buffer buf);
   ~edit_main_rep ();
-  virtual inline void* derived_this () { return (edit_main_rep*) this; }
+  inline void* derived_this () { return (edit_main_rep*) this; }
 
   void        set_property (scheme_tree what, scheme_tree val);
   void        set_bool_property (string what, bool val);

diff --git a/src/Edit/editor.hpp b/src/Edit/editor.hpp
@@ -136,7 +136,7 @@ class editor_rep : public simple_widget_rep {
 public:
   editor_rep ();
   editor_rep (server_rep* sv, tm_buffer buf);
-  inline virtual ~editor_rep () {}
+  virtual ~editor_rep () {}
   bool is_current_editor ();
 
   /* public routines from edit_interface */

diff --git a/src/Graphics/Gui/widget.hpp b/src/Graphics/Gui/widget.hpp
@@ -38,8 +38,8 @@ class widget_rep : public abstract_struct {
 public:
   widget_rep ();
   virtual ~widget_rep ();
-  inline virtual void* derived_this () { return (widget_rep*) this; }
-  virtual tm_ostream&  print (tm_ostream& out);
+  inline void*        derived_this () { return (widget_rep*) this; }
+  virtual tm_ostream& print (tm_ostream& out);
 
   virtual void send (slot s, blackbox val);
   // send a message val to the slot s

diff --git a/src/Graphics/Pictures/effect.hpp b/src/Graphics/Pictures/effect.hpp
@@ -26,7 +26,7 @@ class effect {
 class effect_rep : public abstract_struct {
 public:
   inline effect_rep () {}
-  inline virtual ~effect_rep () {}
+  virtual ~effect_rep () {}
 
   virtual rectangle get_logical_extents (array<rectangle> rs);
   virtual rectangle get_extents (array<rectangle> rs)    = 0;

diff --git a/src/Graphics/Pictures/picture.hpp b/src/Graphics/Pictures/picture.hpp
@@ -40,7 +40,7 @@ class picture_rep : public abstract_struct {
 
 public:
   inline picture_rep () : unique_id (unique_picture_id ()) {}
-  inline virtual ~picture_rep () {}
+  virtual ~picture_rep () {}
 
   inline unsigned long long int get_unique_id () { return unique_id; }
   virtual picture_kind          get_type ()  = 0;

diff --git a/src/Graphics/Pictures/scalable.hpp b/src/Graphics/Pictures/scalable.hpp
@@ -31,7 +31,7 @@ class scalable {
 class scalable_rep : public abstract_struct {
 public:
   inline scalable_rep () {}
-  inline virtual ~scalable_rep () {}
+  virtual ~scalable_rep () {}
 
   virtual scalable_kind get_type ()  = 0;
   virtual void*         get_handle ()= 0;

diff --git a/src/Graphics/Renderer/brush.hpp b/src/Graphics/Renderer/brush.hpp
@@ -19,7 +19,7 @@ enum brush_kind { brush_none, brush_color, brush_pattern };
 class brush_rep : abstract_struct {
 public:
   inline brush_rep () {}
-  inline virtual ~brush_rep () {}
+  virtual ~brush_rep () {}
 
   virtual brush_kind get_type ()  = 0;
   virtual void*      get_handle ()= 0;

diff --git a/src/Graphics/Renderer/pencil.hpp b/src/Graphics/Renderer/pencil.hpp
@@ -26,7 +26,7 @@ class pencil;
 class pencil_rep : abstract_struct {
 public:
   inline pencil_rep () {}
-  inline virtual ~pencil_rep () {}
+  virtual ~pencil_rep () {}
 
   virtual pencil_kind get_type ()  = 0;
   virtual void*       get_handle ()= 0;

diff --git a/src/Graphics/Spacial/spacial.hpp b/src/Graphics/Spacial/spacial.hpp
@@ -38,7 +38,7 @@ class spacial {
 class spacial_rep : public abstract_struct {
 public:
   inline spacial_rep () {}
-  inline virtual ~spacial_rep () {}
+  virtual ~spacial_rep () {}
 
   virtual spacial_kind get_type ()  = 0;
   virtual void*        get_handle ()= 0;

diff --git a/src/Graphics/Types/curve.hpp b/src/Graphics/Types/curve.hpp
@@ -16,9 +16,9 @@
 class curve_rep : public abstract_struct {
 public:
   inline curve_rep () {}
-  inline virtual ~curve_rep () {}
+  virtual ~curve_rep () {}
 
-  inline virtual int nr_components () { return 1; }
+  virtual int nr_components () { return 1; }
   // the number of components of the curve is useful for getting
   // nice parameterizations when concatenating curves
 

diff --git a/src/Graphics/Types/frame.hpp b/src/Graphics/Types/frame.hpp
@@ -20,7 +20,7 @@ class frame_rep : public abstract_struct {
 
 public:
   inline frame_rep () { linear= false; }
-  inline virtual ~frame_rep () {}
+  virtual ~frame_rep () {}
   virtual operator tree ()= 0;
 
   virtual point direct_transform (point p) = 0;

diff --git a/src/Graphics/Types/grid.hpp b/src/Graphics/Types/grid.hpp
@@ -39,7 +39,7 @@ class grid_rep : public abstract_struct {
   inline grid_rep () {}
   inline grid_rep (array<SI> subd2, array<string> col2, point o)
       : subd (subd2), col (col2), center (o) {}
-  inline virtual ~grid_rep () {}
+  virtual ~grid_rep () {}
 
   virtual void set_aspect (tree aspect);
 

diff --git a/src/Kernel/Abstractions/command.hpp b/src/Kernel/Abstractions/command.hpp
@@ -19,9 +19,9 @@ class command_rep : public abstract_struct {
 public:
   inline command_rep () { TM_DEBUG (command_count++); }
   inline virtual ~command_rep () { TM_DEBUG (command_count--); }
-  inline virtual tm_ostream& print (tm_ostream& out);
-  virtual void               apply ()= 0;
-  virtual void               apply (object args);
+  virtual tm_ostream& print (tm_ostream& out);
+  virtual void        apply ()= 0;
+  virtual void        apply (object args);
 };
 
 class command {

diff --git a/src/Plugins/Qt/qt_widget.hpp b/src/Plugins/Qt/qt_widget.hpp
@@ -147,7 +147,7 @@ class qt_widget_rep : public widget_rep {
 
   qt_widget_rep (types _type= none, QWidget* _qwid= 0);
   virtual ~qt_widget_rep ();
-  virtual inline string get_nickname () { return "popup"; }
+  virtual string get_nickname () { return "popup"; }
 
   virtual widget plain_window_widget (string name, command quit, int b= 3);
   virtual widget make_popup_widget ();
@@ -295,7 +295,7 @@ class qt_headless_widget_rep : public qt_widget_rep {
   virtual ~qt_headless_widget_rep () {
     if (DEBUG_QT_WIDGETS) debug_widgets << "~qt_headless_widget_rep" << LF;
   }
-  virtual inline string get_nickname () { return "headless"; }
+  inline string get_nickname () { return "headless"; }
 
   virtual widget plain_window_widget (string name, command quit, int b= 3) {
     (void) name;

diff --git a/src/Plugins/Qt/qt_window_widget.hpp b/src/Plugins/Qt/qt_window_widget.hpp
@@ -49,8 +49,8 @@ class qt_window_widget_rep : public qt_widget_rep {
                         bool fake= false);
   ~qt_window_widget_rep ();
 
-  virtual inline string get_nickname () { return orig_name; }
-  virtual widget        popup_window_widget (string s);
+  virtual string get_nickname () { return orig_name; }
+  virtual widget popup_window_widget (string s);
 
   virtual void     send (slot s, blackbox val);
   virtual blackbox query (slot s, int type_id);

diff --git a/src/Typeset/Bridge/bridge.hpp b/src/Typeset/Bridge/bridge.hpp
@@ -47,7 +47,7 @@ class bridge_rep : public abstract_struct {
 
 public:
   bridge_rep (typesetter ttt, tree st, path ip);
-  inline virtual ~bridge_rep () {}
+  virtual ~bridge_rep () {}
 
   virtual void notify_assign (path p, tree u)= 0;
   virtual void notify_insert (path p, tree u);

diff --git a/src/Typeset/boxes.hpp b/src/Typeset/boxes.hpp
@@ -130,7 +130,7 @@ class box_rep : public abstract_struct {
   /****************************** main routines ******************************/
 
   inline box_rep (path ip);
-  inline virtual ~box_rep ();
+  virtual ~box_rep ();
   void        relocate (path p, bool force= false);
   virtual box transform (frame fr);
   virtual operator tree ()= 0;