Search mode categorization #474

ashesbloom · 2025-01-13T19:29:00Z

📝 Description

Created a basic search mode categorization
- added data-category to all the children of search-with-container (index.html)
- added toggleSearchEngines function in script.js which hides the search options based on search mode
Fixed 'Search With' typo
added Gitignore

⚠️ Important Note ⚠️

Improvements Needed:

Selection Issue
- When the Search mode changes, the selection should return to default.
Animation Enhancement
- Animations must be added and polished to improve the overall user experience.

📸 Screenshots / 📹 Videos

Preview.359.mp4

🔗 Related Issues

✅ Checklist

I have read and followed the Contributing Guidelines.
I have tested my changes by installing them as an extension (not just running via localhost) to ensure it builds, installs, and works as expected.
I have tested these changes in at least Chrome and Firefox (other browsers if applicable).
Attached visual evidence of changes (screenshots or videos) if applicable.

…bloom/materialYouNewTab into Search-Mode-Categorization

added search mode categorization

Thunder-Blaze · 2025-01-14T05:57:23Z

I can add the animations, can you explain the 1st one in a bit more detail

Thunder-Blaze · 2025-01-14T06:03:27Z

Oh then I'll be able to add this too 👍🏻
But I'll need a day, since I'm traveling today back to college 🥲

Thunder-Blaze · 2025-01-16T18:11:41Z

I worked on the 1st problem
umm its working just fine I think
but translations are overwritting again 😢 when I set "search on" as default

any suggestions how to fix ?
current progress -> https://github.com/Thunder-Blaze/MaterialYou-NewTab/tree/Search-Mode-Categorization
once complete @ashesbloom I'll make a PR in your repo

added default search mode selection

…bloom/materialYouNewTab into Search-Mode-Categorization

ashesbloom · 2025-01-16T18:20:15Z

I worked on the 1st problem umm its working just fine I think but translations are overwritting again 😢 when I set "search on" as default

any suggestions how to fix ? current progress -> https://github.com/Thunder-Blaze/MaterialYou-NewTab/tree/Search-Mode-Categorization once complete @ashesbloom I'll make a PR in your repo

@Thunder-Blaze I Just finished the patch a few seconds ago and then read your comment, I was also facing the same issue and I don't think it can be fixed unless the whole structure is tweaked, because z-index, overflow nothing seems to be working so I intertwined the animation

…bloom/materialYouNewTab into Search-Mode-Categorization

ashesbloom · 2025-01-16T18:33:00Z

@prem-k-r ready to be pushed! 🎉

Closes Search mode categorization #474
Related to Bug: Typo error and UI Enhancement for Search Bar Dropdowns #359

#❇️Fixes

When the Search mode changes, the selection returns to the previously selected option.
(if left unselected default engines are 1 on search with and 5 on search on)
Transitions and animations were added for search options.
Fixed width issue when the mode is changed (bug).

#📸Preview

Preview.474.mp4

Thunder-Blaze · 2025-01-16T18:34:43Z

@prem-k-r ready to be pushed! 🎉

Closes Search mode categorization #474

Related to Bug: Typo error and UI Enhancement for Search Bar Dropdowns #359

#❇️Fixes

When the Search mode changes, the selection returns to default i.e. first selection.

Transitions and animations were added for search options.

Fixed width issue when the mode is changed (bug).

#📸Preview

Preview.474.mp4

I made a PR, check it
The selection will return to last used one in it

optimized default selection by utilizing the local storage method!

ashesbloom · 2025-01-16T18:47:28Z

@prem-k-r ready to be pushed! 🎉

Closes Search mode categorization #474

Related to Bug: Typo error and UI Enhancement for Search Bar Dropdowns #359

#❇️Fixes

When the Search mode changes, the selection returns to default i.e. first selection.

Transitions and animations were added for search options.

Fixed width issue when the mode is changed (bug).

#📸Preview
Preview.474.mp4

I made a PR, check it The selection will return to last used one in it

I just finished testing works perfectly well done!
merged!

prem-k-r · 2025-01-16T18:54:18Z

Great work guys!
can you please make Search With and Search On translatable

umm, also maybe we can add ripple effect on button click

Thunder-Blaze · 2025-01-16T19:10:22Z

Great work guys! can you please make Search With and Search On translatable

umm, also can we add ripple effect on button click

@ashesbloom are you working on it or should I finish it ?

ashesbloom · 2025-01-17T04:39:27Z

Great work guys! can you please make Search With and Search On translatable
umm, also can we add ripple effect on button click

@ashesbloom are you working on it or should I finish it

@Thunder-Blaze sure go ahead I am switching to a new issue, will come back time to time though!

Thunder-Blaze · 2025-01-17T04:59:31Z

@Thunder-Blaze sure go ahead I am switching to a new issue, will come back time to time though!

ok 👍🏻

Thunder-Blaze · 2025-01-17T05:28:20Z

@ashesbloom Done, you can check the PR

@prem-k-r I went with simple CSS riple effect otherwise there would've been lots of useless JS added just for one ripple animation

Ripple Effect and Translations

prem-k-r

Issues:

~~If clicked anywhere then page reloaded, the cursor starts from searchbar which is nice but Searchbar outline is not active~~
(Ignorable) clicking effect also there in vertical line
(Ignorable) sometimes there is issue when hide search engine is toggled, not always and resolved when page reloaded

itz-rj-here · 2025-03-06T05:31:07Z

Issues:

~~If clicked anywhere then page reloaded, the cursor starts from searchbar which is nice but Searchbar outline is not active~~

(Ignorable) clicking effect also there in vertical line

(Ignorable) sometimes there is issue when hide search engine is toggled, not always and resolved when page reloaded

@prem-k-r can you like record and show me the ignorable issues? So i can try to fix it.

itz-rj-here · 2025-03-06T09:20:50Z

Default search engine is missing also i am not seeing the dark mode working properly...

itz-rj-here

changes required

prem-k-r · 2025-03-06T09:56:54Z

Issues:

~~If clicked anywhere then page reloaded, the cursor starts from searchbar which is nice but Searchbar outline is not active~~

(Ignorable) clicking effect also there in vertical line

(Ignorable) sometimes there is issue when hide search engine is toggled, not always and resolved when page reloaded

@prem-k-r can you like record and show me the ignorable issues? So i can try to fix it.

Recording.2025-03-06.151938.mp4

And

suppose bing selected
Toggle to hide
choose any from different category, say wikipedia
Change back toggle to show search engines
notice that still in search with option without any radio selected, but in reality it's wikipedia selected

refreshing at any step wont cause this issue

prem-k-r · 2025-03-06T09:58:03Z

Default search engine is missing also i am not seeing the dark mode working properly...

ss/recording pls, I cant replicate this

itz-rj-here · 2025-03-06T11:53:19Z

Default search engine is missing also i am not seeing the dark mode working properly...

ss/recording pls, I cant replicate this

Later. Time to pray. 🙂

itz-rj-here · 2025-03-08T07:52:49Z

When the zoom size is 75%, the mic icon looks misplaced.

This code is the vertical line thingy. now it's for you what can you do to fix it's issue. Ig we may need to remove the vertical line from the searchWithCont code then we can do something with it.

The search with button doesn't shows cursor to pointer

When we hover to the vertical line, sometimes the search with button highlights like it's hovered. But the mouse is hovered to the vertical line.

Now what is this 0.0

prem-k-r · 2025-03-08T08:44:20Z

When the zoom size is 75%, the mic icon looks misplaced.

Ah, didnt noticed.. this issue is in main branch

This code is the vertical line thingy. now it's for you what can you do to fix it's issue. Ig we may need to remove the vertical line from the searchWithCont code then we can do something with it.

The search with button doesn't shows cursor to pointer

fixed

When we hover to the vertical line, sometimes the search with button highlights like it's hovered. But the mouse is hovered to the vertical line.

will see if can do anything to fix the vertical line

Now what is this 0.0

Search with is clickable users might not know, thats why

prem-k-r · 2025-03-08T10:57:20Z

@XengShi feedback please

XengShi · 2025-03-08T11:10:22Z

@XengShi feedback please

Looks great, but the animations need some refinement.

prem-k-r · 2025-03-08T11:29:32Z

@XengShi feedback please

Looks great, but the animations need some refinement.

Yeah, the slide-in animation is little bit not going well with the ui,
I can't help much in this regard :(
you guys can try to refine it :)

ashesbloom added 4 commits January 13, 2025 09:46

added a basic search mode categorization

eadd74b

added basic search mode categorization 2

56e1529

Merge branch 'Search-Mode-Categorization' of https://github.com/ashes…

dbdfca4

…bloom/materialYouNewTab into Search-Mode-Categorization

added gitignore

0526ff5

added search mode categorization

prem-k-r added enhancement New feature or request work in progress The issue is on progress to fix labels Jan 13, 2025

Update .gitignore

2d15a2c

This comment was marked as outdated.

Sign in to view

Thunder-Blaze added 2 commits January 16, 2025 23:26

Added Toggling

7317f6a

Added Fixes

784f78a

ashesbloom added 2 commits January 16, 2025 23:43

fixed search mode bugs and animations

741d0b6

added default search mode selection

Merge branch 'Search-Mode-Categorization' of https://github.com/ashes…

303ab7b

…bloom/materialYouNewTab into Search-Mode-Categorization

Merge branch 'Search-Mode-Categorization' of https://github.com/ashes…

979db7d

…bloom/materialYouNewTab into Search-Mode-Categorization

Merge pull request #1 from Thunder-Blaze/Search-Mode-Categorization

710cd01

optimized default selection by utilizing the local storage method!

prem-k-r mentioned this pull request Jan 16, 2025

Added Browser's default search engine #479

Merged

4 tasks

Ripple Effect and Translations

ffadf1b

Merge pull request #2 from Thunder-Blaze/Search-Mode-Categorization

48f7924

Ripple Effect and Translations

prem-k-r removed the work in progress The issue is on progress to fix label Jan 17, 2025

prem-k-r and others added 5 commits February 23, 2025 17:27

Merge branch 'main' into Search-Mode-Categorization

3e788d3

Merge branch 'main' into Search-Mode-Categorization

c509d79

Update script.js

9d6328d

Update script.js

ffdfdf4

Update style.css

063fed9

prem-k-r requested changes Mar 4, 2025

View reviewed changes

fix focus issue

686bc4c

prem-k-r requested review from XengShi, itz-rj-here and prem-k-r March 5, 2025 17:47

prem-k-r previously approved these changes Mar 5, 2025

View reviewed changes

prem-k-r self-requested a review March 6, 2025 09:00

itz-rj-here requested changes Mar 6, 2025

View reviewed changes

prem-k-r removed the work in progress The issue is on progress to fix label Mar 6, 2025

prem-k-r requested a review from itz-rj-here March 8, 2025 06:44

Mirror changes

113494c

itz-rj-here dismissed prem-k-r’s stale review via 113494c March 8, 2025 07:52

Removed vertical line

03665bf

Merge branch 'main' into Search-Mode-Categorization

96b9c95

prem-k-r approved these changes Mar 9, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Search mode categorization #474

Search mode categorization #474

ashesbloom commented Jan 13, 2025 •

edited by prem-k-r

Loading

Thunder-Blaze commented Jan 14, 2025

This comment was marked as outdated.

Thunder-Blaze commented Jan 14, 2025

Thunder-Blaze commented Jan 16, 2025

ashesbloom commented Jan 16, 2025 •

edited

Loading

ashesbloom commented Jan 16, 2025 •

edited

Loading

Thunder-Blaze commented Jan 16, 2025

ashesbloom commented Jan 16, 2025

prem-k-r commented Jan 16, 2025 •

edited

Loading

Thunder-Blaze commented Jan 16, 2025

ashesbloom commented Jan 17, 2025 •

edited

Loading

Thunder-Blaze commented Jan 17, 2025

Thunder-Blaze commented Jan 17, 2025

prem-k-r left a comment •

edited

Loading

itz-rj-here commented Mar 6, 2025

itz-rj-here commented Mar 6, 2025

itz-rj-here left a comment

prem-k-r commented Mar 6, 2025 •

edited

Loading

prem-k-r commented Mar 6, 2025

itz-rj-here commented Mar 6, 2025

itz-rj-here commented Mar 8, 2025

prem-k-r commented Mar 8, 2025

prem-k-r commented Mar 8, 2025

XengShi commented Mar 8, 2025

prem-k-r commented Mar 8, 2025

Search mode categorization #474

Are you sure you want to change the base?

Search mode categorization #474

Conversation

ashesbloom commented Jan 13, 2025 • edited by prem-k-r Loading

📝 Description

Improvements Needed:

📸 Screenshots / 📹 Videos

🔗 Related Issues

✅ Checklist

Thunder-Blaze commented Jan 14, 2025

This comment was marked as outdated.

Thunder-Blaze commented Jan 14, 2025

Thunder-Blaze commented Jan 16, 2025

ashesbloom commented Jan 16, 2025 • edited Loading

ashesbloom commented Jan 16, 2025 • edited Loading

Thunder-Blaze commented Jan 16, 2025

ashesbloom commented Jan 16, 2025

prem-k-r commented Jan 16, 2025 • edited Loading

Thunder-Blaze commented Jan 16, 2025

ashesbloom commented Jan 17, 2025 • edited Loading

Thunder-Blaze commented Jan 17, 2025

Thunder-Blaze commented Jan 17, 2025

prem-k-r left a comment • edited Loading

Choose a reason for hiding this comment

itz-rj-here commented Mar 6, 2025

itz-rj-here commented Mar 6, 2025

itz-rj-here left a comment

Choose a reason for hiding this comment

prem-k-r commented Mar 6, 2025 • edited Loading

prem-k-r commented Mar 6, 2025

itz-rj-here commented Mar 6, 2025

itz-rj-here commented Mar 8, 2025

prem-k-r commented Mar 8, 2025

prem-k-r commented Mar 8, 2025

XengShi commented Mar 8, 2025

prem-k-r commented Mar 8, 2025

ashesbloom commented Jan 13, 2025 •

edited by prem-k-r

Loading

ashesbloom commented Jan 16, 2025 •

edited

Loading

ashesbloom commented Jan 16, 2025 •

edited

Loading

prem-k-r commented Jan 16, 2025 •

edited

Loading

ashesbloom commented Jan 17, 2025 •

edited

Loading

prem-k-r left a comment •

edited

Loading

prem-k-r commented Mar 6, 2025 •

edited

Loading