Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Typo Error #433

Closed
wants to merge 1 commit into from
Closed

Conversation

bhandaridhyeyh
Copy link

Fixed the typo error in index.html from "Search With" to "Search On"

@itz-rj-here itz-rj-here requested a review from prem-k-r January 4, 2025 05:20
Copy link
Collaborator

@prem-k-r prem-k-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have misunderstood,
it was to split existing Search With to two categories:
Search With: Google, Bing, DuckDuckGo, Brave (Search engines)
Search On: YouTube, Google Images, Wikipedia (platforms)

@itz-rj-here
Copy link
Collaborator

I think you have misunderstood, it was to split existing Search With to two categories: Search With: Google, Bing, DuckDuckGo, Brave (Search engines) Search On: YouTube, Google Images, Wikipedia (platforms)

Yup thats what i though. But he confused me with that changes lol.
Np @bhandaridhyeyh. You maybe misunderstood but this is like when we click on that search with as a button, it will show us a new other categories. Thats all.
I think if you want to help us you could do the changes what the guy asked here. #359
Or you could may close this pr if you think it's hard for you to include it or you don't have that much knowledge on it....

@prem-k-r prem-k-r added invalid This doesn't seem right changes required PR requires updates based on review feedback labels Jan 5, 2025
@prem-k-r prem-k-r marked this pull request as draft January 7, 2025 07:41
@prem-k-r prem-k-r closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes required PR requires updates based on review feedback invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants