Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Batch amendment #2801

Draft
wants to merge 75 commits into
base: main
Choose a base branch
from
Draft

feat: add support for Batch amendment #2801

wants to merge 75 commits into from

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Oct 7, 2024

High Level Overview of Change

This PR:

  • Adds models for the Batch transactions
  • Updates definitions.json to handle the new field types
  • Adds support to the binary codec to properly sign multi-account Batch transactions
  • Adds helper functions for signing and combining multi-account Batch transactions
  • Adds support to autofill for filling in the BatchTxn and TxIDs fields
  • Adds support for Batchnet to the faucets

Context of Change

XRPLF/rippled#5060

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Did you update HISTORY.md?

  • Yes
  • No, this change does not impact library users

Test Plan

Added tests for the new features.

@mvadari
Copy link
Collaborator Author

mvadari commented Nov 7, 2024

Integration tests are expected to fail, since there is an integration test for Batch (which is not in the Docker container yet).

@mvadari mvadari force-pushed the batch branch 7 times, most recently from 3369a0f to f57f0b9 Compare February 6, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants