Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zhuxiangning's personal info #6 #8

Merged
merged 1 commit into from
Jul 4, 2020
Merged

Add zhuxiangning's personal info #6 #8

merged 1 commit into from
Jul 4, 2020

Conversation

zhuxiangning
Copy link

What is the purpose of the change

  • Add zhuxiangning's personal info

Brief change log

  • Add name, educational background, interest and so on.

@CLAassistant
Copy link

CLAassistant commented Jul 3, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

heming6666
heming6666 approved these changes Jul 4, 2020
View reviewed changes
Copy link

@heming6666 heming6666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Great job! Thanks @zhuxiangning .

@menbotics menbotics bot added the pull/approved If a pull is approved, it will be automatically merged label Jul 4, 2020
@menbotics menbotics bot merged commit fbb4bca into X-lab2017:master Jul 4, 2020
@heming6666
Copy link

Related #6.

@leofang327
Copy link
Collaborator

对了，还有一个问题，最好拉一个新的分支来向上游仓库提交PR，并且分支名有实际意义，而不是直接用master分支来向上游提交PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heming6666 heming6666 heming6666 approved these changes

Assignees
No one assigned
Labels
pull/approved If a pull is approved, it will be automatically merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhuxiangning @CLAassistant @heming6666 @leofang327