Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typographical error in DTED Level 2 RPF #20

Merged
merged 1 commit into from
Apr 12, 2019

Conversation

wcmatthysen
Copy link
Member

@wcmatthysen wcmatthysen commented Apr 11, 2019

Description of the Change

Migrated the original pull-request from @rhstone (see pull-request: NASAWorldWind#98 and the corresponding issue: NASAWorldWind#99). According to the original forum-post:

There seems to be duplicate entries in enum RPFDataSeries for DATA_SERIES_D1 and DATA_SERIES_D1. Both have "D1" as and entry for the series code. We are having a problem with world wind displaying the wrong altitude with two different DTED levels. I'm using version 1586.0.0.1. Does anyone know if this is this a known bug? If so, has this been fixed in subsequent versions?

Why Should This Be In Core?

This fixes a bug where WorldWind displays the wrong altitude for two different DTED levels. Looks like a small oversight in the original code.

Benefits

Correct altitude values are displayed for DTED levels.

Potential Drawbacks

None

Applicable Issues

None

@wcmatthysen wcmatthysen added the bug Something isn't working label Apr 11, 2019
@wcmatthysen wcmatthysen added this to the WWJ-CE 2.2.0 milestone Apr 11, 2019
@wcmatthysen wcmatthysen requested a review from emxsys April 11, 2019 18:47
@wcmatthysen
Copy link
Member Author

@emxsys, this looks like an oversight in the original code, but I'm not sure as I'm unfamiliar with RPFDataSeries class. Does the fix look OK to you?

@emxsys
Copy link
Member

emxsys commented Apr 11, 2019

@wcmatthysen I have some RPF data that I will examine.

Copy link
Member

@emxsys emxsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any RPF DTED data for verification. The patterns in the RPFDataSeries certainly indicate a typo for DATA_SERIES_D2. The change looks OK to me.

@emxsys emxsys merged commit 7c9a3ae into WorldWindEarth:develop Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants