Timelock System to all Jobs, Revival PR. #692
Open
+842
−171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtjunior743
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Previously i made this PR back in december that took to long to get reviewed(over 2 weeks) and had to close because of multiple conflict merges. now it is back with the fixes and new code for the new jobs.
New timelock system based on your playtime of your jobs, this was mainly ported from the cm-ss13 codebase and then adapted to fit this code.
Preference Menu after 2 hours of playtime (Ignoring race and clans limitations)
Choose Profession for a new player(Old sc without the Clinic, but without 2 hours of any of these roles they can't play doctor):
Once they play 2 hours of any role(Admin bypass is active so it is ignoring races limitations):
[To test this you need to set up the DB(dbconfig.txt for the info), enable tracking at config.txt and disable the admin bypass, there is one at preferences.dm and another at the new_player.dm]
Why It's Good For The Game
Easy system to implement for jobs, guide new players towards more friendly roles and make them play abit of some more simple roles to move into the complex ones.
Changelog
🆑
add: Increased the limit in the preference from 17 to 18 so it don't looks ugly
add: Add new timelock system for jobs
add; Add time locks for all jobs besides the new player ones
fix: Fixed an issue with generation reqs showing before even checking if your clan or race could play that role.
code: New define for the jobs titles, straight from __DEFINES/jobs
code: New folders for each group of jobs, based off the join menu, each group got their own dm besides the antags but police, giovanni and primogen still a single dm with all their jobs.
/:cl: