CPLAT-3094 Lifecycle Error Boundary #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As an update with where this currently stands... This implementation is working but the We are able to get at the dart exception in ways laid out in the ticket but we are hoping to get sign off from the dart team before moving forward with that... because this is branched from #160 that has not been merged yet a cleaner diff can be found here: kealjones-wk/react-dart@react-16-new-context...cleandart:CPLAT-3094-lifecycle-error-boundary |
aaronlademann-wf
requested changes
Apr 3, 2019
# Conflicts: # lib/react.js.map # lib/react_with_addons.js.map # lib/react_with_react_dom_prod.js.map # package-lock.json
…s/react16/CPLAT-3094-lifecycle-error-boundary
…ndart/react-dart into CPLAT-3094-lifecycle-error-boundary Catch up local branch with remote
aaronlademann-wf
requested changes
Apr 5, 2019
aaronlademann-wf
previously requested changes
Apr 16, 2019
greglittlefield-wf
requested changes
Apr 16, 2019
greglittlefield-wf
requested changes
Apr 17, 2019
Co-Authored-By: joebingham-wk <[email protected]>
Merged
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to allow for the possibility of React 16 error boundaries, we needed to add
getDerivedStateFromErrorandcomponentDidCatchlifecycle events. However, we also needed to ensure that not every component becomes and error boundary. Consequently,skipMethodswas introduced toregisterComponent.Changes
componentDidCatch.getDerivedStateFromError.skipMethods._filterSkipMethodsto ensure that a consumer cannot skip important lifecycle events._dart_helpers.jsremoving lifecycle events based upon the final skipMethods list.react_test.dartTesting Suggestions