FED-2880 Fix Blink-based Microsoft Edge Browser Detection #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Comment on lines
+59
to
+63
| expect([browser.isChrome, browser.isEdgeChrome], everyElement(isTrue), | ||
| reason: | ||
| 'Blink-based Edge browser should be detected as both Chrome and Edge ' | ||
| 'since feature support is based on Chrome, but should identify as Edge ' | ||
| 'for logging purposes'); |
There was a problem hiding this comment.
This test ensures that any consumer's pre-existing feature-based business logic keying off of isChrome remains unchanged for Edge browsers.
aaronlademann-wf
requested review from
robbecker-wf,
brettkail-wk,
kealjones-wk and
sorenthompson-wk
robbecker-wf
previously approved these changes
Jun 28, 2024
|
@Workiva/release-management-pp |
|
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the modern Edge browser gets detected as
Chrome- which is not ideal for logging purposes.The browser - from a feature-set standpoint - literally IS
Chrome- so it should remain being detected as such, but its name/version should reflect the application itself - not just the platform it is built atop of.Also boy scouted some missing test coverage for the legacy (MSIE-based) Edge browser.