Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FED-3274 React 18 Prep #973

Merged
merged 9 commits into from
Feb 4, 2025
Merged

FED-3274 React 18 Prep #973

merged 9 commits into from
Feb 4, 2025

Conversation

sydneyjodon-wk
Copy link
Contributor

@sydneyjodon-wk sydneyjodon-wk commented Jan 31, 2025

Motivation

A couple test updates in order to get tests passing on React 18

Changes

  • Update context tests similar to react-dart since changedBits doesn't work on React 18
  • Update ErrorBoundary prod tests to use react_dom.render to avoid RTL error about using act in prod builds
  • Update analyzer plugin to fix analysis errors on Dart 3 (these were also happening in master)

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Frameworks Design member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@sydneyjodon-wk sydneyjodon-wk marked this pull request as ready for review January 31, 2025 17:08
Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions, but otherwise LGTM

Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment; thanks for fixing that analyzer plugin issue!

tools/analyzer_plugin/pubspec.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changes look good
  • CI passes with React 18 pulled in
  • Assuming CI passes again on this PR on the latest commit

+10

@sydneyjodon-wk
Copy link
Contributor Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@btr-rmconsole-2 btr-rmconsole-2 bot merged commit 471dccf into master Feb 4, 2025
9 checks passed
@btr-rmconsole-2 btr-rmconsole-2 bot deleted the test-react-18-prep branch February 4, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants