Delete WebAuthn key

[iandunn]

See #193

This adds the functionality for deleting a key. Design will be refined in #194, so this PR only focuses on the code. The Registration flow will be completed in #200, so this PR only focuses on the deletion flow.

---

---

---

[renintw]

Saw error messages when inputting. Has it been noticed and expected to be fixed in #194?

--

Also, I saw two keys always with the name New Key added when registering a new key while sandboxed or non-sandboxed, is it expected behavior at the moment?

--

And I couldn't Remove the key, it would get 400 error also on both sandbox and local env, is it expected at the moment as well or I might've missed some settings?

[iandunn]

Saw error messages when inputting

I noticed that too, but the Registration flow is still just a stub from #95. The only reason I made a change to it in this PR was because I needed to decouple it from the Deletion flow (see 5973b13)

The Deletion flow is what this PR is really about.

two keys always with the name New Key added when registering a new key while sandboxed or non-sandboxed, is it expected behavior at the moment?

Yeah, that's just throwaway code from #95, it's only purpose is to demonstrate the flow to Design, and give us a code skeleton to iterate on. The deletion process should be working fully in this PR though.

I couldn't Remove the key, it would get 400 error

That's definitely a problem, but I haven't been able to reproduce it. Can you check that the handle and _ajax_nonce fields in the POST request match their values in wp-admin/profile.php? Look for them in the data- attributes in .webauthn-keys span.delete a.

Also make sure that wp-admin isn't asking you to revalidate the 2fa session. Thanks!

[renintw]

Saw error messages when inputting

I noticed that too, but the Registration flow is still just a stub from #95. The only reason I made a change to it in this PR was because I needed to decouple it from the Deletion flow (see 5973b13)
The Deletion flow is what this PR is really about.

two keys always with the name New Key added when registering a new key while sandboxed or non-sandboxed, is it expected behavior at the moment?

Yeah, that's just throwaway code from #95, it's only purpose is to demonstrate the flow to Design, and give us a code skeleton to iterate on. The deletion process should be working fully in this PR though.

👍

I couldn't Remove the key, it would get 400 error

That's definitely a problem, but I haven't been able to reproduce it. Can you check that the handle and _ajax_nonce fields in the POST request match their values in wp-admin/profile.php? Look for them in the data- attributes in .webauthn-keys span.delete a.

Also make sure that wp-admin isn't asking you to revalidate the 2fa session. Thanks!

I see the problem. I thought I could directly register a new key using the button provided and then delete it, but then I realized that the Register Key functionality has not been implemented yet, as there's an open PR for it. I've added webauthn key manually and successfully deleted it on sandbox 👍 Sorry for the confusion.

[iandunn]

Ah, that makes sense, my bad for not giving clearer testing instructions!