Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bail early if WebAuthn plugin missing. #176

Merged
merged 1 commit into from
May 25, 2023
Merged

Bail early if WebAuthn plugin missing. #176

merged 1 commit into from
May 25, 2023

Conversation

dd32
Copy link
Member

@dd32 dd32 commented May 23, 2023

See #172

iandunn
iandunn approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@iandunn iandunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we should update the envs to install the plugin in order to close the issue, but this LGTM in the mean time 👍🏻

@dd32
Copy link
Member Author

dd32 commented May 24, 2023

I'm not against updating the environments too, I just think given this is an MU-plugin used everywhere, we should fail gracefully

@StevenDufresne StevenDufresne merged commit e6db44a into trunk May 25, 2023
@StevenDufresne StevenDufresne deleted the fix/local-envs-webauthn branch May 25, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iandunn iandunn iandunn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dd32 @iandunn @StevenDufresne