Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine WebAuthn visual design #194

Closed
iandunn opened this issue May 26, 2023 · 8 comments · Fixed by #223
Closed

Refine WebAuthn visual design #194

iandunn opened this issue May 26, 2023 · 8 comments · Fixed by #223
Assignees
Milestone

Comments

@iandunn
Copy link
Member

iandunn commented May 26, 2023

#95 stubbed in the rough code and UI, and #193 added real data/functionality.

In this PR we should refine that UI to match @jasmussen 's design. I think Steve's idea of a Primary indicator is helpful too.

Canonical Figma:

@iandunn iandunn added this to the Iteration 1 milestone May 26, 2023
@iandunn iandunn self-assigned this May 26, 2023
This was referenced May 26, 2023
@iandunn
Copy link
Member Author

iandunn commented May 26, 2023

Hey @jasmussen 👋🏻 I noticed a few differences between this and the TOTP flow:

  • After setting up TOTP, the user is redirected to Backup Codes, but here they're redirected back to the Security Keys intro screen.
  • TOTP adds a snackbar-esque notice on success, but this doesn't.
  • TOTP has a button to disable it, but this doesn't.

Should the two screens be more consistent? What do you think about both screens redirecting to Backup Codes if they're not already setup, but back to the totp/security-key screen if backup codes are already setup?

@jasmussen
Copy link
Collaborator

Any discrepancies are very likely to mainly be my lack of full understanding of the flow, so no reason to make too big of a detour. If you can provide me with screenshots of the flow, I'm happy to adjust, provide the remaining screens, or give feedback if perhaps we can optimize a part of it.

@adamwoodnz
Copy link
Contributor

adamwoodnz commented Aug 8, 2023

If you can provide me with screenshots of the flow

@jasmussen here are the differences

TOTP has a button to disable it, but this doesn't.

The Disable security keys button below isn't shown in the designs, but to be consistent with TOTP we could add it.

TOTP Security Keys
Screenshot 2023-08-08 at 3 07 57 PM Screenshot 2023-08-08 at 3 08 09 PM

After setting up TOTP, the user is redirected to Backup Codes, but here they're redirected back to the Security Keys intro screen.
TOTP adds a snackbar-esque notice on success, but this doesn't.

After successfully adding an app or registering a key, the final destination screens look like this:

TOTP -> Backup codes Security Keys -> list screen
Screenshot 2023-08-08 at 3 24 42 PM Screenshot 2023-08-08 at 3 27 51 PM

@jasmussen
Copy link
Collaborator

From those screenshots, it looks like a decent enough starting point to me. I might have used the tertiary style for "Disable security keys" since it sits next to a primary button, but the secondary style works okay 👍 👍

@adamwoodnz
Copy link
Contributor

@jasmussen what do you think about the end of the flow; should we redirect to the Backup Codes screen with the success notification (like TOTP), or is it better to stay on the list screen?

IMO a success notification feels like it should be added in both cases.

@jasmussen
Copy link
Collaborator

Is that partially covered by this sketch?

If yes, the idea there was to show a spiner, then a success animation, then after n seconds, redirect back.

@adamwoodnz
Copy link
Contributor

show a spiner, then a success animation, then after n seconds, redirect back

Oh yes, let's go with that then, maybe the success animation can replace all the success notices we currently use

@jasmussen
Copy link
Collaborator

maybe the success animation can replace all the success notices we currently use

If the actions are small and not too substantial, I think a notice/snackbar can be fine.

In the flow suggested above, the animation exists because the action is a bit more substantial, i.e. connecting a security key. I imagine scanning a QR code is also a substantial action. Deleting a key, or something like that, would not be substantial and can just be confirmed more simply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants