Add site logo theme support to bundled themes #8236
+305
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up where @narenin was at and addresses the twenty-ten, twenty-eleven and twenty-twelve themes.
Twenty-Thirteen and Twenty-Fourteen need to be discussed further before moving forward with any development:
1 - Twenty-Thirteen currently has the anchor tag wrapping the linked text and the site description. This should be updated so that the anchor tag lives inside the h1 and the h2/description is not linked at all.
2 - Twenty-Fourteen may not be suitable for a logo due to the size limitations of the logo area on this theme.
Trac ticket: https://core.trac.wordpress.org/ticket/61766
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.